Improve CLI for flint_masking #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 7, 2024 17:24
Closed
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 59.79% 60.32% +0.53%
==========================================
Files 33 33
Lines 5686 5727 +41
==========================================
+ Hits 3400 3455 +55
+ Misses 2286 2272 -14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some interest has been received around using some of the masking operations for use via a cli. Upon inspection it was pretty clear the cli was out of date and fairly primitive.
This change improves the CLI, and marks an early version of the minimum box car artifact masker as deprecated and to be removed.
A separate erosion mode based on the shape of the restoring beam has also been added.
Some other bits of dead code has been removed, and some light reordering of the internals / keyword parameters.
Tests have been added for some of the new features, and some have been modified in anticipation of removing the older minimum box car artifact masker.